-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usability: Add Ctrl+Shift+F shortcut to search the main tracks database #13200
base: main
Are you sure you want to change the base?
Conversation
1a95d62
to
46facc1
Compare
46facc1
to
55d557f
Compare
Note that there is already |
@ronso0 Thanks, I will have a look! I'll have to place the shortcut handling somewehere else, though, so it also works when the search widget is disabled (this behavioris inherent to Sidenote: There seem to be at at least three ways to define keyboard shortcut actions and associated key sequences right now:
Option 3 is only active when keyboard shortcuts are enabled in the options, but when it is, it (mostly) overrides the other two. Maybe it makes sense to integrate the "(Custom) keyboard shortcuts disabled" codepath into |
How about adding "Search in Tracks" to the Library menu? |
f5fe605
to
0210e1b
Compare
0210e1b
to
4d386c8
Compare
It now uses the format also used by the rest of the application.
…urrently focused This scenario occurs e.g. when calling setLibraryFocus from a menu action. The popup window has already been closed when QAction::triggered occurs, but the main window has not yet gotten its focus back. As per the documentation of QWidget::setFocus(), when the containing window is not active, the focus change request is delayed until the window becomes active - which is exactly what we want in our case.
caef3f3
to
22f171e
Compare
The new shortcut
Ctrl+Shift+F
(Search globally
1) compliments the existing shortcutCtrl+F
(Search in current location
).The use case for this is pretty simple (and motivated by me teaching dance classes) and probably pretty common elsewhere, too:
Footnotes
Ok, it is only "globally" as long as all tracks are present in the main Mixxx database, and not contained in external libraries like iTunes or Rekordbox.2 ↩
As a later improvement, one could extend
Ctrl+Shift+F
to, either:a. Actually initiate a global search over all available libraries, or:
b. Make default library to which
Ctrl+Shift+F
jumps configurable in the preferences, or:c. Provide different shortcuts for the different external libraries. ↩