AutoDJProcessor: Calculate and expose the number of tracks and accurate total duration in the Auto DJ queue #13183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The time_remaining and tracks_remaining controls in the [AutoDJ] can be used to display the information about the Auto DJ queue in custom skins. The current calculation method for the time_remaining control only considers the total duration of the tracks by themselves, and does not take the transition times between tracks into account.
This is a first step in generalizing the transition logic in AutoDJProcessor to enable it to also be applied to tracks in the queue instead of just the current decks.
This is another step in generalizing the transition logic in AutoDJProcessor to enable calculating transition times for the whole queue.
This is the final step in generalizing the core transition timing logic in AutoDJProcessor, so that it can be applied to a whole playlist instead of just the current decks.
…n relevant The following data points are used as inputs for the "remaining time" calculation, and should therefore trigger a recalculation: * The list of tracks in the Auto DJ playlist (both the set of tracks and their order are important). We subscribe to PlaylistTableModel::tracksChanged to receive the relevant notifications. * The AutoDJ transition mode and transition time settings. We will be notified via ::setTransitionMode and ::setTransitionTime, respectively. * The Intro, Outro & N60dBSound cues of all tracks that are contained in the Auto DJ queue. We subscribe to TrackCollection::tracksChanged and TrackCollection::multipleTracksChanged to receive notifications about possible changes. As of now, we do not filter the notifications, and simply trigger a recalculation when ANY track has changed.
…for the remaining time & tracks
cr7pt0gr4ph7
force-pushed
the
autodj-time-remaining
branch
from
dca71bf
to
1923d12
Compare
…accounting for transition times)
cr7pt0gr4ph7
force-pushed
the
autodj-time-remaining
branch
from
1923d12
to
2f5f0ea
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The calculated total duration take into account the transition modes, transition time etc. (in fact, it reuses the code that performs the actual transition during queue playing).
The
time_remainingandtracks_remainingare exposed asControlObjects so they can be consumed by skins.