Macros Backend respin #13172
Open
Macros Backend respin #13172
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Ignoring return value of function declared with 'nodiscard' attribute -Missing include
…ter clear, but clear intentional leaves a user specified label untouched
JoergAtGithub
force-pushed
the
macros-backend
branch
from
9ac8800
to
d61749c
Compare
acolombier
reviewed
May 6, 2024
| @@ -227,6 +227,18 @@ EngineBuffer::EngineBuffer(const QString& group, | |||
| m_pCueControl = new CueControl(group, pConfig); | |||
| addControl(m_pCueControl); | |||
|
|
|||
| for (int i = 1; i <= kMacrosPerChannel; ++i) { | |||
| auto* pMacroControl = new MacroControl(group, pConfig, i); | |||
There was a problem hiding this comment.
Looks like this might currently be leaked. Perhaps should be replaced by a unique_ptr
I think there are only the three GSoC pages in our wiki, and the original PRs of cause. One aim of this feature was to achieve compatibility to Serato Flip, to allow data import from Serato. Therefore I guess, that the Serato Flip feature is similar to use: https://support.serato.com/hc/en-us/articles/203157550-Serato-Flip-User-Guide |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is #4528 with fixed CI and solved merge conflicts.
It implements the following COs without GUI: https://github.com/mixxxdj/mixxx/wiki/Macros