Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for reading and writing to AWS S3 buckets #746

Open
wants to merge 18 commits into
base: main
Choose a base branch
from
Open

Add support for reading and writing to AWS S3 buckets #746

wants to merge 18 commits into from

Conversation

camdenmoors
Copy link
Collaborator

Adds support for reading and writing to S3

@camdenmoors camdenmoors marked this pull request as ready for review October 12, 2022 18:31
@aaronlippold
Copy link
Member

Did we update the documentation on the README? I don't see that.

@aaronlippold aaronlippold added the enhancement New feature or request label Oct 12, 2022
@camdenmoors
Update README.md
223e949
@camdenmoors
Update io.ts
67225fa 
Some sites (such as GitHub) don't support HEAD on files.
@aaronlippold aaronlippold changed the title Add Alternative Input/Output modes Add support for reading and writing to AWS S3 buckets Oct 20, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 10, 2022

This pull request has a conflict. Could you fix it @camdenmoors?

aaronlippold
aaronlippold reviewed Dec 19, 2022
View reviewed changes
src/utils/io.ts
parsedURI = new URL(uri)
logger.debug(`Parsed URI: ${uri} - Protocol is ${parsedURI.protocol}`)
} catch {
return fs.readFileSync(uri, encoding)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this really the best place in our 'switch' statement to get the 'I am reading a file from the filesystem' case?

@aaronlippold
Copy link
Member

We seem to be missing unit tests

@aaronlippold aaronlippold linked an issue Dec 29, 2022 that may be closed by this pull request
Upload -o output file to s3 #376
Open
@mergify
Copy link
Contributor

mergify bot commented May 1, 2023

This pull request has a conflict. Could you fix it @camdenmoors?

1 similar comment
@mergify
Copy link
Contributor

mergify bot commented Jun 13, 2023

This pull request has a conflict. Could you fix it @camdenmoors?

@charleshu-8
Merge branch main into io_modes
b1e1bfd 
Signed-off-by: Charles Hu <chu@mitre.org>
@mergify
Copy link
Contributor

mergify bot commented Jun 20, 2023

This pull request has a conflict. Could you fix it @camdenmoors?

charleshu-8 and others added 2 commits June 30, 2023 15:04
@charleshu-8
Merge main
9783e22 
Signed-off-by: Charles Hu <chu@mitre.org>
@charleshu-8
Merge branch 'main' into io_modes
c67bc0a
@sonarcloud
Copy link

sonarcloud bot commented Jul 5, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@mergify
Copy link
Contributor

mergify bot commented Jul 29, 2023

This pull request has a conflict. Could you fix it @camdenmoors?

4 similar comments
@mergify
Copy link
Contributor

mergify bot commented Sep 11, 2023

This pull request has a conflict. Could you fix it @camdenmoors?

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 5, 2023

This pull request has a conflict. Could you fix it @camdenmoors?

@mergify Mergify
Copy link
Contributor

mergify bot commented Jan 16, 2024

This pull request has a conflict. Could you fix it @camdenmoors?

@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 5, 2024

This pull request has a conflict. Could you fix it @camdenmoors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aaronlippold aaronlippold aaronlippold left review comments

@Amndeep7 Amndeep7 Awaiting requested review from Amndeep7

@em-c-rod em-c-rod Awaiting requested review from em-c-rod

At least 1 approving review is required to merge this pull request.

Assignees

@camdenmoors camdenmoors

Labels
enhancement New feature or request Needs Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Upload -o output file to s3
3 participants
@camdenmoors @aaronlippold @charleshu-8