Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nested groups #4746

Draft
wants to merge 63 commits into
base: master
Choose a base branch
from
Draft

Nested groups #4746

wants to merge 63 commits into from

Conversation

Rlin232
Copy link
Contributor

@Rlin232 Rlin232 commented Jul 25, 2023 •
edited by georgedias

This PR needs a detailed description of the objectives, to include an ERD diagram for the implemented Nested Groups.

@Rlin232
Created model and module for new group-relations table
dc88cea 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Interfaces for group relation DTOs
cf72feb 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added new interfaces to export
b90e59e 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Removed unnecessary interface and created DTOs
f81abdd 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Refactored DTOs to include childId and made childId unique
77e3f86 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Created group-relations.service, removed unnecessary interface
da2e40d 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Controller is unnecessary for this case, as all operations are bundle…
c8bfcff 
…d in groups.service

Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Created group-relations-controller
a9141b3 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
GroupRelations table migration script
975ca5a 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Display for parentGroup
174c286 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added group relations to vuex store
fd0b067 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added GroupRelationsModule to AppModule
8f28221 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added functionality to save group relations
3fb0202 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232 Rlin232 linked an issue Jul 25, 2023 that may be closed by this pull request
Nested groups #4707
Open
Rlin232 and others added 16 commits July 31, 2023 08:40
@Rlin232
Now tracking response info instead of existing group info upon group …
f617d17 
…creation

Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Removed incorrect field in group-relations.service find method
ad3c356 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Computed values for initial parent group ID
548f2ba 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added descendant getters for groups in the backend
f35f689 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added descendant getters for groups in the store
26c314a 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Initial groups treeview implementation
78aa4b1 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Set initial parent group ID internal so it does not delete on save
24fccc8 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Initial display for selected group
47c2476 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Merge branch 'master' into nested-groups
465dbf4
@Rlin232
Fixed undefined groupRole issue
a51dc1d 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added group ID to display
1e86088 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added check for cyclic groups in frontend
3386248 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added check for cyclic groups in backend
9748161 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Moved info icon next to ID
2f340e5 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Fixed reactivity issues with groups page
b766cfe 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added users table for group view
fcba046 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Recursive delete as opposed to preservative, and delete only for admins
58c67af 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Changed ability of owners in a group to exclude delete permissions
fac809f 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Using relative import to pass tests
e8d787d 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added in linter-removed import
c174eab 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Separated descendant helper functions into utility class, added desce…
1b0e8c2 
…ndant groups on frontend for results

Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added results visibility for child group members in the backend
8f59fa7 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Allowing child group owners to edit evaluations
2e1a83b 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Letting only admins or owners add child groups in the frontend
1c28df8 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Made public-true default on frontend
679ceb7 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Disabled private child groups and parent groups on the frontend
587c55a 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Disallowed saving group relationss if you are not an owner in the bac…
598f966 
…kend

Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Checks for private group nesting in the backend
7fd2be7 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added grouprelationsn to testing modules
5cad712 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Relative import path caused tests to fail
eff91d9 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Expected behavior for group deletion changed. Now only admins can delete
328daa6 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Reverted back to original function for displaying/editing evaluations
412d27a 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Searching for treeview instead of datatable in groups cypress test
6590fd6 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Made new verifier class for treeview
d095e8a 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Relative imports and initial cypress test changes
8425712 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added GroupRelations to evaluations test module
f62d856 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Changing to click the parent of the span in groups.cy test
cf31585 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Test for admin to delete group
45015b9 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Rearranged logins for tests
b6ef248 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Added child member support - still need way to dynamically track chil…
68ec349 
…d group membership

Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Removed unnecessary TODOs
d0347c0 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Recursive delete of child members
50686e3 
Signed-off-by: Rlin232 <rlin@mitre.org>
@Rlin232
Revert "Recursive delete of child members"
941108f 
This reverts commit 50686e3.
@sonarcloud
Copy link

sonarcloud bot commented Aug 18, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 7 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@mergify Mergify
Copy link
Contributor

mergify bot commented Dec 12, 2023

This pull request has a conflict. Could you fix it @Rlin232?

1 similar comment
@mergify Mergify
Copy link
Contributor

mergify bot commented Feb 6, 2024

This pull request has a conflict. Could you fix it @Rlin232?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Nested groups
1 participant
@Rlin232