Add "Mark All As Viewed" checkbox in results view #4666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Rlin232 <rlin@mitre.org>
|
Kudos, SonarCloud Quality Gate passed!
|
Amndeep7
requested changes
Jul 10, 2023
| this.viewedControlIds = []; | ||
| this.allViewed = Trinary.Off; | ||
| } else { | ||
| this.items.forEach((item) => { |
| this.allViewed = Trinary.Off; | ||
| } else { | ||
| this.items.forEach((item) => { | ||
| if (!this.viewedControlIds.includes(item.control.data.id)) { |
There was a problem hiding this comment.
if all you need to do is add unique values to the list, then make 'viewedControlIds' a set so that that process is automatically handled by the data structure
There was a problem hiding this comment.
Frontend tests are failing
There was a problem hiding this comment.
I don't want the button to show/hide checkmarked results to change. I want a new button that lets me checkmark/de-checkmark all the controls
There was a problem hiding this comment.
when PRs are still WIP don't forget to mark them as draft please
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.