Objectdetection #268
Objectdetection #268
Conversation
| /** | ||
| * Dimensions of the video frame | ||
| */ | ||
| DIMENSIONS = [480, 360]; |
There was a problem hiding this comment.
This property should really be centralized onto the video mixin. Want to update that code to include this property? https://github.com/mitmedialab/prg-extension-boilerplate/blob/dev/extensions/src/common/extension/mixins/optional/video.ts
There was a problem hiding this comment.
Also, I think it'd be better to encode this as an object as
{ width: number, height: number }(instead of an array)
| arg: { | ||
| type: "number", | ||
| defaultValue: 5, | ||
| handler: (x) => { |
There was a problem hiding this comment.
Hm, is the handler actually doing? @pmalacho-mit to look
There was a problem hiding this comment.
@pmalacho-mit Looks like it isn't doing anything... Did I put the handler in the right spot?
There was a problem hiding this comment.
@jimbo797 ya, I think this is in the wrong spot. Did your editor not give you errors? Here's what it looks like for me:
There was a problem hiding this comment.
You only have a handler when you have a menu that accepts reporters. So this would be correct (but note you'll need to deal with typescript errors because the input to the handler is of type uknown so you'll need to do some casting to make it happy):
|
frisbee... |
| text: (state) => `Turn continuous detection ${state}`, | ||
| arg: { type: ArgumentType.Boolean, options: [{ text: 'on', value: true }, { text: 'off', value: false }] } | ||
| }) | ||
| async continuouslyDetectObjects(state) { |
There was a problem hiding this comment.
You'll need to specify that the state argument is a boolean for typescript to be happy. Is your editor not showing you errors? Here's what it looks like for me:
|
Nice, @jimbo797 ! Few more comments for you to check out. Also, go generate a cool thumbail and logo, please! |
|
(sorry, @jimbo797 I accidentally closed this. Ignore that!) |
No description provided.