Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support moving static ode to another server #3134

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

jisqyv
Copy link
Member

@jisqyv jisqyv commented Mar 6, 2024

This permits serving the static portions of ode (the Javascript code and translations) from another web server, including via a third party CDN such as Cloudflare.

Change-Id: Ic70ca21419c67be66e5c9011c42d53bafe9367bf

@jisqyv
Copy link
Member Author

jisqyv commented Mar 8, 2024

@ewpatton Note: this is now running on jisqyvap4.appspot.com

@jisqyv
Copy link
Member Author

jisqyv commented Mar 13, 2024

Rebased onto current master

Copy link
Member

@ewpatton ewpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor things and other points of discussion.

This permits serving the static portions of ode (the Javascript code
and translations) from another web server, including via a third party
CDN such as Cloudflare.

Change-Id: Ic70ca21419c67be66e5c9011c42d53bafe9367bf
@jisqyv jisqyv marked this pull request as ready for review April 10, 2024 14:22
Copy link
Member

@ewpatton ewpatton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor code cleanup and two unresolved comments from earlier.

@jisqyv jisqyv added this to the ai2-test milestone May 8, 2024
jisqyv added 6 commits May 8, 2024 13:02
Also updated the Copyright comment

Change-Id: Ia1822d2a50a896a2565a8e90dd172aed0ca4dbe0
Also refactored the imports

Change-Id: Id2b11e31d5e3c73f9c0285cabea278001fe17a7b
Change-Id: Id100580089a8c2ca32da0d7dc1465779403921fb
Also updated copyright date

Change-Id: I0aaa7614a3bf157f276b7d018d91f77c7426d904
Change-Id: I7eb4bc46636db1b6be95e5a42579acc6524abc98
Change-Id: Id67c8751fc98217b9020886ba7fdd6a85f13e3e6
@jisqyv jisqyv modified the milestones: ai2-test, nb197 May 15, 2024
@jisqyv jisqyv added the on ai2-test Code is deployed on ai2-test.appinventor.mit.edu label May 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants