New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support moving static ode to another server #3134
base: master
Are you sure you want to change the base?
Conversation
@ewpatton Note: this is now running on jisqyvap4.appspot.com |
Rebased onto current master |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor things and other points of discussion.
appinventor/appengine/src/com/google/appinventor/client/Ode.java
Outdated
Show resolved
Hide resolved
appinventor/appengine/src/com/google/appinventor/client/Ode.java
Outdated
Show resolved
Hide resolved
...tor/appengine/src/com/google/appinventor/client/editor/simple/components/MockFirebaseDB.java
Outdated
Show resolved
Hide resolved
appinventor/appengine/src/com/google/appinventor/shared/storage/StorageUtil.java
Show resolved
Hide resolved
appinventor/appengine/src/com/google/appinventor/shared/storage/StorageUtil.java
Outdated
Show resolved
Hide resolved
This permits serving the static portions of ode (the Javascript code and translations) from another web server, including via a third party CDN such as Cloudflare. Change-Id: Ic70ca21419c67be66e5c9011c42d53bafe9367bf
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor code cleanup and two unresolved comments from earlier.
...tor/appengine/src/com/google/appinventor/client/editor/simple/components/MockFirebaseDB.java
Outdated
Show resolved
Hide resolved
...tor/appengine/src/com/google/appinventor/client/editor/simple/components/MockFirebaseDB.java
Outdated
Show resolved
Hide resolved
appinventor/appengine/src/com/google/appinventor/client/utils/Downloader.java
Outdated
Show resolved
Hide resolved
appinventor/appengine/src/com/google/appinventor/client/wizards/ComponentUploadWizard.java
Outdated
Show resolved
Hide resolved
appinventor/appengine/src/com/google/appinventor/shared/rpc/ServerLayout.java
Outdated
Show resolved
Hide resolved
appinventor/appengine/src/com/google/appinventor/shared/rpc/ServerLayout.java
Show resolved
Hide resolved
appinventor/appengine/src/com/google/appinventor/shared/storage/StorageUtil.java
Show resolved
Hide resolved
appinventor/appengine/src/com/google/appinventor/shared/storage/StorageUtil.java
Outdated
Show resolved
Hide resolved
Also updated the Copyright comment Change-Id: Ia1822d2a50a896a2565a8e90dd172aed0ca4dbe0
Also refactored the imports Change-Id: Id2b11e31d5e3c73f9c0285cabea278001fe17a7b
Change-Id: Id100580089a8c2ca32da0d7dc1465779403921fb
Also updated copyright date Change-Id: I0aaa7614a3bf157f276b7d018d91f77c7426d904
Change-Id: I7eb4bc46636db1b6be95e5a42579acc6524abc98
Change-Id: Id67c8751fc98217b9020886ba7fdd6a85f13e3e6
This permits serving the static portions of ode (the Javascript code and translations) from another web server, including via a third party CDN such as Cloudflare.
Change-Id: Ic70ca21419c67be66e5c9011c42d53bafe9367bf