:universal option for zlib formula #1106
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mistydemeo
reviewed
May 6, 2024
|
I believe this is due to another issue for which I ought to have submitted a pull request first (I apologize for the confusion). In brief, Superenv has three methods which modify HOMEBREW_ARCHFLAGS (m32, m64, and universal_binary). None of them contain the call to Correcting this deficiency causes the majority (of formulae I have since attempted) to build successfully with this same trivial :universal option. I suspect that the present PR will work just fine under stdenv, which does not suffer the same deficiency. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
trivial edit. appears to work fine with no active intervention. Have not tried it on Tiger because no way to test the Intel half.