Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken --c++11 option #1087

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

gsteemso
Copy link
Contributor

(broken regexp common to ENV/std.rb and ENV/super.rb, causing C++11 test to always fail under gcc-7)

(broken regexp common to ENV/std.rb and ENV/super.rb, causing C++11 test to always fail under gcc-7)
Copy link
Owner

@mistydemeo mistydemeo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if GNU_GCC_REGEXP is the right constant here. It covers all GCCs in Tigerbrew, from 4.3 onward, but GCC didn't have a full C++11 implementation until 4.8 - which is the version this other regex aims to cover. https://gcc.gnu.org/projects/cxx-status.html

@gsteemso
Copy link
Contributor Author

gsteemso commented Mar 25, 2024 via email

@gsteemso
Copy link
Contributor Author

I've re-done this so there's a standard, defined-once C++11-aware-GCC regexp right below the standard, defined-once GCC-in-general regexp (in compilers.rb), and tweaked stdenv/superenv to use it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants