Sections #398

rsterbin · 2016-12-01T15:20:58Z

This is a new feature allowing you to add subqueries ("sections") with their own sets of filters.

Tests and existing plugins work, but not all features available to the root group are available for sections.

NB: I don't know MongoDB, so I've added an error if you try to use getRules and you have a section defined, but I hope that someone else can add that functionality.

Merge request checklist

I read the guidelines for contributing
I created my branch from dev and I am issuing the PR to dev
Unit tests are OK
If it's a new feature, I added the necessary unit tests
If it's a new language, I filled the __locale and __author fields

… clear it out

… and add one when an id is selected

… clear it out

… and add one when an id is selected

…to sections

…o filter error messages

…upport to the MongoDB plugin

- removed the custom base sql option, which rightfully belongs in a plugin - added tests

mistic100 · 2016-12-01T15:33:57Z

WOW that's a lot of changes, it will take a while to review and test.

Awesome work BTW;

rsterbin · 2016-12-01T15:44:26Z

Thanks! It looks like I'll need to add some more tests to get coverage up. Would you rather I hold off on that till you've had a chance to make a first pass review?

mistic100 · 2016-12-01T15:45:39Z

Go ahead, I can't do it right away.

mistic100 · 2016-12-04T18:09:40Z

src/defaults.js

@@ -112,9 +124,15 @@ QueryBuilder.DEFAULTS = {
    allow_empty: false,
    conditions: ['AND', 'OR'],
    default_condition: 'AND',
+    allow_sections: true,
+    has_sections: false,


Shouldn't this be in this.prop ?

Yep. Will move.

mistic100 · 2016-12-04T18:12:04Z

src/model.js

+                return !section.group.contains(node, true);
+            }
+            else {
+                return true;


not false ?

Should be; will fix.

mistic100 · 2016-12-04T18:13:20Z

src/plugins/change-filters/plugin.js

        var self = this;

-        if (filters === undefined) {
+        if (Object.prototype.toString.call(delete_orphans) === '[object Array]') {


https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/isArray

Old js knowledge is old. Will fix.

mistic100 · 2016-12-04T18:22:32Z

src/template.js

+ * @param stypes {array}
+ * @return {string}
+ */
+QueryBuilder.prototype.getSectionTypeSelect = function(section, stypes) {


Can't find any usage of this method.

mistic100 · 2016-12-04T18:23:40Z

examples/index.html

+    {
+      id: 'subquery-a',
+      label: 'Subquery A',
+      base_sql: 'SELECT a_id FROM section_a WHERE parent_id = 10 AND ',


Derp, forgot to remove that.

mistic100 · 2016-12-04T18:27:27Z

General remarks :

I don't understand what is "stype", more over because the "getSectionTypeSelect" method is not used.
the "exist" keyword used everywhere does not seem adapted to me, in the sense that sections should not bounded to "exists" and "not exists" only, it should be called "section_type" or something like that.
although the feature is very powerful, I would prefer to ship it as a plugin and not integrated in the core. I know it would be a huge rework and I don't know if everything can be a moved in a plugin yet.

The main problem I think is that it currently only works with "EXISTS" and "NOT EXISTS", it would be great to make it work with any operand that supports a subquery (about every operand actually). But in order to make it work, the builder needs to be able to build select clauses (like asked here #310).
Your opinion ?

rsterbin · 2016-12-05T15:07:11Z

Section type (stype) is where you select which section you want to add. I'd initially called it "section_id" -- which makes more sense but collided with the internal section ID. I'm definitely open to calling it something else! (The function getSectionTypeSelect is called in core.js on line 706; were you talking about a different one?)

I like the idea of binding subqueries to different kinds of operators, and I'd be interested in doing that in the future, if there's a way to expand in that direction. I chose EXISTS/NOT-EXISTS because that's the shortest path to getting working sections -- my client has a lot of business logic that means I'm not really modeling the full subquery, just offering them a proxy of sorts to it and building the query from json later. Asking whether they want the section to be present or not is the only logical distinction they care about at this time. (Although now that you bring up the possibility, I could certainly see them asking for that functionality in the future.)

My first attempt at writing this was as a plugin, but I ran into trouble because it changes the group->rule structure. I do know a lot more about the code now than I did then, though, so let me think about it and see if I can't come up with a way to rework this as a plugin that spawns extra builders within a special rule. I'm somewhat concerned I won't have enough time to get that big a change done by the time my client needs it, but I'll see what I can do.

rsterbin · 2016-12-05T17:32:23Z

Quick update: I'm working on a little proof of concept using a plugin:
https://github.com/rsterbin/jQuery-QueryBuilder/tree/subquery-plugin

The main problem right now is finding a way to prevent the buttons within the subquery from triggering events in the base query. If I can find a workaround for it, I think a plugin solution is possible.

mistic100 · 2016-12-07T10:14:26Z

e.stopPropagation() in every listener should work
https://github.com/mistic100/jQuery-QueryBuilder/blob/dev/src/core.js#L237

rsterbin · 2016-12-07T14:39:54Z

That did the trick. I'll push forward with the plugin and see if I can get it up to where this one is before I close it out.

…nique-filter plugin

…g the exists flag

cheizer · 2017-06-03T17:58:47Z

Hello, I was wondering what the status of this plugin was? I tried getting the source and running bower install in the project and was unable to get it to work. I'm kinda green when it comes to how to compile all of this so I'm not sure how to proceed.

Thanks!

anthonyblond · 2018-02-05T05:26:12Z

I'm also curious if this progressed further. Perhaps at another location?

rsterbin · 2018-02-05T14:35:16Z

Sorry, my client decided not to pursue this feature, so it's effectively abandoned. If anyone wants to pick it up, the most recent work is here -- https://github.com/rsterbin/jQuery-QueryBuilder/tree/subquery-plugin

se · 2018-11-22T22:52:39Z

Do you guys think to add this feature?

Reha Sterbin added 30 commits October 14, 2016 12:57

Began work on adding sections (placeholder commit)

baa79ce

Set basic styles for sections

4291680

Partially working type selection

c33383b

Fixed a bug in swapping the section-exists flag

ad69458

Set up json building and validation for sections

b3e29dc

When switching section types, add an empty rule to the group after we…

9a34dfa

… clear it out

Implemented allow_sections and section flags

248f2d9

Set allow_sections in the example

989967e

Unless we have a default section id, create the section with no group…

6d249e8

… and add one when an id is selected

Began work on adding sections (placeholder commit)

6e1d3ad

Set basic styles for sections

4440b58

Partially working type selection

8094d49

Fixed a bug in swapping the section-exists flag

323bfc4

Set up json building and validation for sections

f945379

When switching section types, add an empty rule to the group after we…

e7e09df

… clear it out

Implemented allow_sections and section flags

a771cf4

Set allow_sections in the example

d9959dd

Unless we have a default section id, create the section with no group…

543b87b

… and add one when an id is selected

Merge branch 'sections' of github.com:rsterbin/jQuery-QueryBuilder in…

164acbe

…to sections

Fixed a merge error

3943f67

Fixed linting and style errors

3dfdf29

You can now set section data from JSON

1a3fa87

Fixed linting/style warnings

ff606d4

More bug fixes for sections

1c16555

Invert plugin passes tests and works for sections

6df52ff

Broke section checking into its own method and added section detail t…

0ac0326

…o filter error messages

Fixed a logical error in setRules

b7fc580

First pass at sections test suite (only currently passing tests for now)

8e6b42e

Rounded out section tests and made allow_sections default to true

d0a8ec6

Removed allow_sections from the example

360fece

Reha Sterbin added 7 commits November 24, 2016 13:58

Added support for sections to the SQL plugin and an error about non-s…

ed48873

…upport to the MongoDB plugin

Tests for get-sql sections support

96b5847

Test for get-mongo sections error

fa0a2ab

Setting sections from SQL works now; also:

187bdac

- removed the custom base sql option, which rightfully belongs in a plugin - added tests

Fixed linting and style warnings

a2a041e

Put sections in right include location

8d550fe

Merge branch 'dev' into sections

cf5395c

mistic100 added the feature New feature label Dec 1, 2016

mistic100 reviewed Dec 4, 2016

View reviewed changes

Reha Sterbin added 5 commits December 8, 2016 11:46

Increased test coverage and fixed a bug in the sections part of the u…

a46736a

…nique-filter plugin

Added a test for inverting on sections and fixed a bug in auto-settin…

71d8cec

…g the exists flag

Added testing of default unique filters

5db5f73

Added a test for remove filter on a section

9fe66f5

Forgot about section flags

e3966f3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sections #398

Sections #398

rsterbin commented Dec 1, 2016

mistic100 commented Dec 1, 2016

rsterbin commented Dec 1, 2016

mistic100 commented Dec 1, 2016

mistic100 Dec 4, 2016

rsterbin Dec 5, 2016

mistic100 Dec 4, 2016

rsterbin Dec 5, 2016 •

edited

mistic100 Dec 4, 2016 •

edited

rsterbin Dec 5, 2016

mistic100 Dec 4, 2016

mistic100 Dec 4, 2016

rsterbin Dec 5, 2016

mistic100 commented Dec 4, 2016

rsterbin commented Dec 5, 2016

rsterbin commented Dec 5, 2016

mistic100 commented Dec 7, 2016

rsterbin commented Dec 7, 2016

cheizer commented Jun 3, 2017

anthonyblond commented Feb 5, 2018

rsterbin commented Feb 5, 2018

se commented Nov 22, 2018

Sections #398

Are you sure you want to change the base?

Sections #398

Conversation

rsterbin commented Dec 1, 2016

mistic100 commented Dec 1, 2016

rsterbin commented Dec 1, 2016

mistic100 commented Dec 1, 2016

mistic100 Dec 4, 2016

Choose a reason for hiding this comment

rsterbin Dec 5, 2016

Choose a reason for hiding this comment

mistic100 Dec 4, 2016

Choose a reason for hiding this comment

rsterbin Dec 5, 2016 • edited

Choose a reason for hiding this comment

mistic100 Dec 4, 2016 • edited

Choose a reason for hiding this comment

rsterbin Dec 5, 2016

Choose a reason for hiding this comment

mistic100 Dec 4, 2016

Choose a reason for hiding this comment

mistic100 Dec 4, 2016

Choose a reason for hiding this comment

rsterbin Dec 5, 2016

Choose a reason for hiding this comment

mistic100 commented Dec 4, 2016

rsterbin commented Dec 5, 2016

rsterbin commented Dec 5, 2016

mistic100 commented Dec 7, 2016

rsterbin commented Dec 7, 2016

cheizer commented Jun 3, 2017

anthonyblond commented Feb 5, 2018

rsterbin commented Feb 5, 2018

se commented Nov 22, 2018

rsterbin Dec 5, 2016 •

edited

mistic100 Dec 4, 2016 •

edited