Add aria-label for previous and next page links #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you! I've added a feature where the text of these labels can be translated for each language. |
ChrisBr
reviewed
Jun 1, 2023
| end | ||
|
|
||
| def previous_or_next_page(page, text, classname) | ||
| def previous_or_next_page(page, text, classname, aria_label = nil) |
There was a problem hiding this comment.
@mislav Just FYI this break custom link renderer because it changed the signature.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a product named EZOfficeInventory (https://www.ezofficeinventory.com). In this product, we are using will_paginate gem to provide pagination to our clients.
BBC News is one of our clients. We noticed that when we focus on previous or next page icons then the screen reader just read them as just "link" instead of the previous or next page. It creates confusion for the person with a vision disability.
Now we are now adding an aria-label class with those two link buttons so they can be called correctly.