Skip to content

Commit

Permalink
Fix Ruby 2.4 test failures re: loofah + nokogiri
Browse files Browse the repository at this point in the history
Loofah 2.21 started depending on a Nokogiri "HTML4" feature
that is not available in a version of Nokogiri compatible
with Ruby 2.4.
  • Loading branch information
mislav committed May 29, 2023
1 parent a3610ef commit 8039e7d
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 0 deletions.
3 changes: 3 additions & 0 deletions environments/Gemfile.rails5.0.rb
Original file line number Diff line number Diff line change
Expand Up @@ -13,3 +13,6 @@

gem 'mysql2', '~> 0.5.2', :group => :mysql
gem 'pg', '~> 1.2.3', :group => :pg

# ruby 2.4 compat re: nokogiri
gem 'loofah', '< 2.21.0'
3 changes: 3 additions & 0 deletions environments/Gemfile.rails5.1.rb
Original file line number Diff line number Diff line change
Expand Up @@ -12,3 +12,6 @@

gem 'mysql2', '~> 0.5.2', :group => :mysql
gem 'pg', '~> 1.2.3', :group => :pg

# ruby 2.4 compat re: nokogiri
gem 'loofah', '< 2.21.0'
3 changes: 3 additions & 0 deletions environments/Gemfile.rails5.2.rb
Original file line number Diff line number Diff line change
Expand Up @@ -11,3 +11,6 @@
gem 'sqlite3', '~> 1.3.6'
gem 'mysql2', '~> 0.5.2', :group => :mysql
gem 'pg', '~> 1.2.3', :group => :pg

# ruby 2.4 compat re: nokogiri
gem 'loofah', '< 2.21.0'

0 comments on commit 8039e7d

Please sign in to comment.