Rename Authenticator.server_{cert,key}_fingerprint #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By dropping the server_ prefix. The functions do not check that the certificate have extended key usage of server auth and could just as well be used to authenticate clients (although the server case is more likely). The old names are kept as aliases and a deprecation attribute is added.
The names server_cert_fingerprint and server_key_fingerprint may suggest to the user that the functions check the extended key usage is server auth. This change clarifies this is not the case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By dropping the server_ prefix. The functions do not check that the certificate have extended key usage of server auth and could just as well be used to authenticate clients (although the server case is more likely). The old names are kept as aliases and a deprecation attribute is added.
This may result in some churn, but judging from sherlocode it doesn't look too bad.