Fix factory types #1011
Open
Fix factory types #1011
+7
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wagenet
force-pushed
the
better-factory-types
branch
from
59d155b
to
2644c0f
Compare
jasikpark
reviewed
Mar 9, 2022
| @@ -181,7 +181,7 @@ declare module "miragejs/-types" { | |||
| } | |||
|
|
|||
| type WithFactoryMethods<T> = { | |||
| [K in keyof T]: T[K] | ((n: number) => T[K]); | |||
| [K in keyof T]: T[K] | ((this: FlattenFactoryMethods<T>, n: number) => T[K]); | |||
There was a problem hiding this comment.
What exactly does this do?
As I understand it, it takes a factory and translates method return types into basic types, so
{
age: number;
height: () => string;
}becomes
{
age: number;
height: string;
}There was a problem hiding this comment.
I believe that is correct.
|
Unfortunately, there's still a lot of messiness around types in Mirage. I'm not sure whether it's still worth merging this so if someone thinks it's good to close, that's ok with me. |
|
Thanks for taking a crack at this, @wagenet. I'd love to get the types cleaned up, but if I recall correctly, this PR had some failing type tests. If you're willing to work on them and get them passing, I'll be happy to review. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.