aarch32 support #78
Open
aarch32 support #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
reviewed
Jun 26, 2020
| HOST="--host=$(BUILD_ARCH)-unknown-linux-gnueabihf" | ||
| UNDEF_SDL=echo '\#undef SUPPORT_DYNAMIC_LINKING' >> ocaml/runtime/caml/s.h | ||
| # TODO: This is not a good way to pass the TARGET_XX and SYS_XX check in ./build/ocaml/runtime/signals_osdep.h | ||
| DROP_TARGET=sed -i -e 's/(TARGET_arm)/(TARGET)/' ocaml/runtime/signals_osdep.h |
There was a problem hiding this comment.
this is fine for the current OCaml releases, but we (@mirage/core) should upstream a cleanup of OCaml's configure and signals_osdep.h ifdef chain so we don't have to specify linux-gnueabihf and sed -i -e in the OCaml distribution.
hannesm
reviewed
Jun 26, 2020
config.in/Makefile.Linux.arm
Outdated
| HOST=arm-linux-gnueabihf | ||
| FLAMBDA=false | ||
| SAFE_STRING=false | ||
| MAX_TESTSUITE_DIR_RETRIES=0 |
There was a problem hiding this comment.
these files (Makefile.Linux.arm and m.arm.h) should not be needed, but fully generated by our execution of OCaml's configure.
|
This looks nice, but unfortunately is now outdated (now that solo5 0.7 and mirage 4 is out) -- maybe someone would like to rebase / rethink this "solo5 on 32 bit" work? /cc @TheLortex |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modification is required to add aarch32 as an architecture supported by Solo5, and related to the pull request at Solo5/solo5#470.