Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP/2 types for h2-mirage #978

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anmonteiro
Copy link
Contributor

@anmonteiro anmonteiro commented Apr 4, 2019

This diff allows running HTTP/2 unikernels with https://github.com/anmonteiro/ocaml-h2

lib/mirage_impl_http.ml Outdated Show resolved Hide resolved
@samoht
Copy link
Member

samoht commented Apr 8, 2019

Is there any hope to have a common HTTP/1 et HTTP/2 interface for unikernels? I know @TheLortex tried to have a common API the cohttp and httpaf but I'm not sure that's really the way forward anymore. One solution would be to evolve the cohttp API to look way more like httpaf.

@avsm
Copy link
Member

avsm commented Apr 8, 2019

@samoht: yes, see anmonteiro/ocaml-h2#37

@anmonteiro
Copy link
Contributor Author

@samoht reverted the formatting. I figured out what happened. I have auto-formatting on save setup in Vim when it detects and ocamlformat project, and there's indeed a config file in this repo :)

@samoht
Copy link
Member

samoht commented Apr 8, 2019

@avsm sweet! Can we get this somehow as a combinator? For an end-user perspective, it doesn't really make sense to offer 3 different http devices...

@TheLortex
Copy link
Member

Blocker for the common API are PRs in httpaf that enables a Mirage adapter and response with upgrade:
inhabitedtype/httpaf#83 and inhabitedtype/httpaf#91

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants