Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "use the .opam.locked file for installing the switch dependencies" #1477

Merged
merged 1 commit into from Oct 25, 2023

Conversation

hannesm
Copy link
Member

@hannesm hannesm commented Oct 24, 2023

Reverts #1462

The issue is outlined in #1476 -- with the code as is, the opam install --deps-only $< pin-depends everything (even those packages only meant for the duniverse. Let's revert that commit, and suffer from #1415

@hannesm
Copy link
Member Author

hannesm commented Oct 24, 2023

An alternative would be to embed yet another option into the makefile, namely --ignore-pin-depends -- to avoid the pinning of a million packages. BUT this would break in non-obvious ways a package installation if at some point we'd have a pin-depend in that opam file that is not ?vendor / ?monorepo'd.

@dinosaure
Copy link
Member

I've convinced myself that this is the best solution for the time being.

@dinosaure dinosaure merged commit 944a83a into main Oct 25, 2023
2 of 3 checks passed
@dinosaure dinosaure deleted the revert-1462-fix-1415 branch October 25, 2023 08:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants