Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makefile: opam install the lock file #1415

Open
reynir opened this issue Mar 29, 2023 · 3 comments · Fixed by #1462
Open

Makefile: opam install the lock file #1415

reynir opened this issue Mar 29, 2023 · 3 comments · Fixed by #1462

Comments

@reynir
Copy link
Member

reynir commented Mar 29, 2023

According to this comment we need to opam install the lockfile:

tarides/opam-monorepo#378 (comment)

But in the code we install the .opam file (and not the .opam.locked file):

https://github.com/mirage/mirage/blob/main/lib/functoria/makefile.ml#L138-L140

CC @TheLortex @samoht

@TheLortex
Copy link
Member

Indeed we should install the .opam.locked file

@reynir
Copy link
Member Author

reynir commented Oct 25, 2023

Reopening this as #1462 was reverted. It seems given the current state of opam-monorepo we should not opam install the lock file but also we should(?!) it would be good to have clarified the expectations of opam-monorepo and what the workflow should look like.

@reynir reynir reopened this Oct 25, 2023
@hannesm
Copy link
Member

hannesm commented Oct 27, 2023

When installing the lockfile, we ended up in #1476 which adds lots of pins to the current opam switch. An option would be to --ignore-pin-depends -- but in the end, I'm more interested in which concrete issue "using the lockfile" would solve.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants