Unix: copy buffer before passing off to client #502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannesm
reviewed
Feb 9, 2023
hannesm
reviewed
Feb 9, 2023
| let b = Cstruct.create_unsafe len in | ||
| Cstruct.blit buf 0 b 0 len; | ||
| b | ||
| in |
There was a problem hiding this comment.
Cstruct.copy is Cstruct.t -> int -> int -> string, that is, Cstruct.copy t off len is the same as Cstruct.to_string t ~off ~len :/ I didn't see a function to copy a cstruct (even though Cstruct.copy would be an obvious name for such a function)
There was a problem hiding this comment.
Hi @palainp, indeed, Cstruct.sub_copy does what I want, but it only exists in unreleased cstruct. I can put a comment in the code to use Cstruct.sub_copy in the future.
There was a problem hiding this comment.
Oh sorry, didn't checked the last release date :(
There was a problem hiding this comment.
I will cut a release of cstruct as soon as I can but some improvements are not merged yet.
dinosaure
approved these changes
Feb 10, 2023
hannesm
added a commit
to hannesm/opam-repository
that referenced
this pull request
Mar 17, 2023
CHANGES: * TCP: add ID for PCB for connection tracking (mirage/mirage-tcpip#495 @TheLortex) * Unix stack, UDP: copy buffer before passing it to client (mirage/mirage-tcpip#502 @reynir) * API renamings (due to ppx_cstruct removal): accessors such as Icmpv4_wire.get_icmpv4_ty are now Icmpv4_wire.get_ty ("_icmpv4" is removed) (mirage/mirage-tcpip#505) * Use Cstruct.to_string instead of deprecated Cstruct.copy (mirage/mirage-tcpip#506 @hannesm) * Remove ppx_cstruct dependency (mirage/mirage-tcpip#505 @hannesm) * Remove mirage-profile dependency (mirage/mirage-tcpip#504 @hannesm) * Remove Mirage3 cross-compilation runes (mirage/mirage-tcpip#507 @hannesm) * opam: add lower bounds for cmdliner and alcotest (mirage/mirage-tcpip#506 @hannesm)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Originally reported by @rand00.