Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irmin-pack: add context for corrupted control file #2224

Merged
merged 1 commit into from Mar 27, 2023

Conversation

metanivek
Copy link
Member

This PR adds context to the Corrupted_control_file error to let us distinguish the different control files: upper layer and volumes in lower layer.

This lets us distinguish the different control files: upper layer and
volumes in lower layer.
@metanivek metanivek added the no-changelog-needed No changelog is needed here label Mar 23, 2023
Copy link
Contributor

@adatario adatario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@adatario
Copy link
Contributor

adatario commented Mar 24, 2023

Also related: #2141 (reworking error-types)

Copy link
Contributor

@clecat clecat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@metanivek metanivek merged commit 3b93d8d into mirage:main Mar 27, 2023
3 of 5 checks passed
@metanivek metanivek deleted the corrupt_cf_error branch March 27, 2023 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed No changelog is needed here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants