Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

irmin-pack: throw exception for readonly batch #2066

Merged
merged 3 commits into from Sep 5, 2022

Conversation

metanivek
Copy link
Member

This is a small follow up based on #1987 (comment). I also added a test for this small change. I didn't see a place to put this sort of direct repo test, so I created a new test file.

Copy link
Contributor

@icristescu icristescu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, LGTM!

@metanivek metanivek added the no-changelog-needed No changelog is needed here label Sep 5, 2022
@metanivek metanivek merged commit 179421a into mirage:main Sep 5, 2022
@metanivek metanivek deleted the readonly-batch-exn branch September 5, 2022 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-changelog-needed No changelog is needed here
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants