Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Songs downloaded as clean version when they aren't supposed to. #406

Open
NotADevBtw opened this issue Dec 30, 2022 · 3 comments
Open

Songs downloaded as clean version when they aren't supposed to. #406

NotADevBtw opened this issue Dec 30, 2022 · 3 comments
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed

Comments

@NotADevBtw
Copy link

NotADevBtw commented Dec 30, 2022

Some songs downloaded off Apple Music seems to be downloaded as a clean version while other songs from the same album isn't, listening to the preview of the song in Apple Music indicates the song isn't clean however Freyr seems to download a clean version for whatever reason.

Some songs this has occurred on:

I am sure there is other songs that this is occurring on as well but these are from my personal experience.

To reproduce:

  • Download the entire album
  • Play the song
  • Song is the clean version
    Edit: This also happens when downloading the same song separately.
    Edit 2: This doesn't happen when downloading songs from Spotify, only from Apple Music, I don't know about Deezer still as I won't try it since I don't really use it.

This is on a fresh install of Freyr (version 0.9.0) on Arch Linux, as I said above other songs from the same album is downloaded without issues but these two I listed is downloaded as a clean version, I'll listen to other songs from different albums and artists and report back, I don't know if this issue occurs on different services (Spotify & Deezer) since I haven't tried them.

@NotADevBtw
Copy link
Author

@NotADevBtw
Copy link
Author

I think I figured it out, seems like it’s not an issue with freyr itself rather than the fact that when using YouTube Music as a source it might download the audio from a clean version since it’s what show up first, using YouTube instead of YouTube Music as the source seems to fix this.

@miraclx
Copy link
Owner

miraclx commented Jan 9, 2023

Hi @NotADevBtw, sorry for the delayed response. Ideally, we should be able to fix this. One potential approach is to search by ISRC on YouTube Music instead of the current implementation of searching for the title+artist(s) and filtering for best-match. Especially since the classification criteria doesn't include explicitness.

I'll reopen this issue, so we can track its resolution. Thanks for providing all the links. They are+will be useful.

@miraclx miraclx reopened this Jan 9, 2023
@miraclx miraclx added enhancement New feature or request help wanted Extra attention is needed good first issue Good for newcomers labels Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants