Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DJ Sets / Freyr downloads "wrong" tracks #418

Open
tobeehh opened this issue Jan 15, 2023 · 1 comment
Open

DJ Sets / Freyr downloads "wrong" tracks #418

tobeehh opened this issue Jan 15, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@tobeehh
Copy link

tobeehh commented Jan 15, 2023

When downloading DJ sets, Freyr seems to download the "wrong" titles, meaning the "standalone" ones without the transitions. Especially in DJ Sets, this leads to rough transitions within the album. An example can be found here:
https://music.apple.com/de/album/a-state-of-trance-1000-celebration-mix-mixed-by/1549277933

Is this expected behaviour due to freyr simply searching for title/artist or can this be fixed somehow?

@miraclx
Copy link
Owner

miraclx commented Jan 16, 2023

One possible solution is mentioned in #406 (comment)

One potential approach is to search by ISRC on YouTube Music instead of the current implementation of searching for the title+artist(s) and filtering for best-match. Especially since the classification criteria doesn't include explicitness.

But observing the first track on the album you referenced - "A State of Trance 1000 - Celebration Mix (Intro - The Boy on His Bike) [Mixed]", its ISRC is NLF712100555 of which there are no matching results.

So, we can start off with an ISRC check for best-match, and falling back to textual search if that fails for the best results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants