Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows allegro to be used as a QM/MM DeltaMLP which corrects the QM/QM and nearby QM/MM interactions without altering MM/MM interactions.
Description
Motivation and Context
In the context of QM/MM, one would have "QM atom types" and "MM atom types". The elements of the mask correspond to QM/QM, QM/MM, or MM/MM interactions. One would set all QM/QM and QM/MM edge interactions to true and all MM/MM edge interactions to false. This is necessary to conserve energy as MM atoms flow into and out of the QM region's vicinity. This strategy is analogous to the DPRc model based on DeePMD-kit (doi: 10.1021/acs.jctc.1c00201). The changes made here are highly related to a pull request made to nequip (mir-group/nequip#427) which adds a per_species_rescale_shifts_mask option.
How Has This Been Tested?
cd tests && pytest nn/
log attached as tests_nn.logcd tests && pytest model/
can make it through 60% of test_allegro.py without error but then my computer runs out of memory. This is not specific to this particular PR; it happens whn I test the nequip+allegro develop branches too. I should test the main branches and open a separate issue.Types of changes
Checklist:
black
.docs/options
) has been updated with new or changed options.CHANGELOG.md
.