Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix assignment of mp_stacks_magnificPopup #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

acurrieclark
Copy link

Attempting to edit any of the bricks in my stacks currently results in a

Uncaught TypeError: Cannot read property 'open' of null

error on the mp_stacks_magnificPopup variable. A little bit of digging in the console revealed that the instance property on $.magnificPopup was always null, but the $.magnificPopup itself has the open() and close() functions we need.

Hopefully this is a genuine fix and not just some bizarre quirk that I am seeing.

@mintplugins
Copy link
Owner

@acurrieclark Thanks for the PR! I haven't experienced this, but I will test it out asap.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants