Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for ingress in kubernetes v1.22 and backwards compatibility to dex-k8s-authenticator #192

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Maqui-LP
Copy link

The extensions/v1beta1 and networking.k8s.io/v1beta1 API versions of Ingress is no longer served in kubernetes v1.22 (https://kubernetes.io/docs/reference/using-api/deprecation-guide/#ingress-v122)

This pull request adds support for ingress in dex-k8s-authenticator for kubernetes v1.22 and provides backwards compatibility to other kubernetes versions

Copy link

@Foxlik Foxlik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've been running these changes for a few weeks now. The change works well for 1.23.

Copy link

@juanpsm juanpsm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can confirm this works with version 1.22.3. It's exactly what helm create chart gives as example

Copy link

@jppitout jppitout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@fsdrw08
Copy link

fsdrw08 commented Oct 8, 2022

/merge

@darkgordon
Copy link

Yep it works !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants