Added Annotations section to Deployment template

[VF-mbrauer]

To make it possible to have an annotations section defined which we can fill with data. Right now it is static data and just filled with checksum/config:
This makes it more flexible to give also other customized key/value pairs defined there.

[nabadger]

Could we call this podAnnotations - since these are only applied to the pod-spec and not top-level deployment.

In addition could we provide defaults in values.yaml to make it clear it's an option, someting like:

podAnnotations: { }

nodeSelector: {}

tolerations: []

affinity: {}

[VF-mbrauer]

Hi @nabadger, sorry for my late reply. Yes we could do that exactly as you described. So podAnnotations is fine as well as the definition of `podAnnotations: { } in the value file.

[nabadger]

@VF-mbrauer - just wondering if you saw my reply or not, and whether these changes are still required?

Thanks

[jengo]

I would personally like to see this merged in. I need annotations to allow connecting to hashicorp vault.

[VF-mbrauer]

@VF-mbrauer - just wondering if you saw my reply or not, and whether these changes are still required?

Thanks

Hi @nabadger, apologize for the late reply. I found also another way of implementation on our side via Admission Controller functionality, but I still see this feature as important as for users not implementing this that way I mentioned. Therefore this should be implemented the way we discussed already. Thanks.

[nabadger]

@VF-mbrauer would you be able to rename this to podAnnotations? If not I can do this in a different MR and merge it in :)

[VF-mbrauer]

Hi @nabadger, yes of course. Feel free to amend for me and get it merged. Then we can finally close this thread. Thanks.

[VF-mbrauer]

@nabadger Any news here. Did you amend and merged that in the meantime?