Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move /cluster/audit to /audit #19708

Merged
merged 4 commits into from May 10, 2024

Conversation

anjalshireesh
Copy link
Contributor

Community Contribution License

All community contributions in this pull request are licensed to the project maintainers
under the terms of the Apache 2 license.
By creating this pull request I represent that I have the right to license the
contributions to the project maintainers under the Apache 2 license.

Description

As the audit metrics are server level and not overall cluster level.

Motivation and Context

More meaningful metrics endpoints

How to test this PR?

curl "http://<endpoint>/minio/metrics/v3/audit"

should return the audit related metrics

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Optimization (provides speedup with no functional changes)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • Fixes a regression (If yes, please add commit-id or PR # here)
  • Unit tests added/updated
  • Internal documentation updated
  • Create a documentation update request here

As the audit metrics are server level and not overall cluster level.
@anjalshireesh anjalshireesh marked this pull request as ready for review May 9, 2024 14:32
@donatello
Copy link
Member

Why not group node level that is not resource/hw related under /node at top-level (like audit, webhook, etc)?

@harshavardhana harshavardhana merged commit 60d7e81 into minio:master May 10, 2024
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants