add ios pwa meta #2548
Merged
add ios pwa meta #2548
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fguillot
reviewed
Mar 21, 2024
| <meta name="mobile-web-app-capable" content="yes"> | ||
| <meta name="apple-mobile-web-app-title" content="Miniflux"> | ||
| <meta name="apple-mobile-web-app-status-bar-style" content="black-translucent"> |
There was a problem hiding this comment.
Does it have the same issue mentioned in PR #1667?
See screenshots in this comment: #1667 (comment)
There was a problem hiding this comment.
ye it‘s same issue and it's work fine in safari pwa
so i delete it and only add viewport-fit=cover to use css env() get safe-area in ios pwa
rootknight
added a commit
to rootknight/Miniflux-Theme-Reeder
that referenced
this pull request
Mar 21, 2024
fguillot
reviewed
Mar 29, 2024
| @@ -6,7 +6,7 @@ | |||
| <title>{{template "title" .}} - Miniflux</title> | |||
|
|
|||
| <meta http-equiv="X-UA-Compatible" content="IE=edge"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | |||
| <meta name="viewport" content="width=device-width, initial-scale=1.0, viewport-fit=cover"> | |||
There was a problem hiding this comment.
I don't see any difference when testing. Can you point me to the viewport-fit=cover documentation?
There was a problem hiding this comment.
https://developer.mozilla.org/en-US/docs/Web/CSS/env#usage
This change does not affect the current official theme, but third-party themes can use it to adapt to the iOS safe-area，like this
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add meta to support ios pwa status bar color and css env()
Do you follow the guidelines?