Add API to replace an existing async job #14602
Draft
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an API to replace existing async jobs. The new job is queued if the old job cannot be replaced (e.g. if the old job is already run).
See above
The async engine attempts to replace the existing queue if possible and falls back to queueing the new job.
Job cancellation is trivially implemented based on this by replacing the old job with an empty function.
Partially addresses No proper way to deal with async job interdependencies / no cancellation #13681
See linked issue.
See linked issue.
To do
This PR is a Work in Progress.
How to test
The new API should be covered by unittests.
Note that I have not yet figured out how to test certain things mentioned in the PR, such as canceling existing async jobs on shutdown.