Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Android CI: Additionally make an AAB for uploading to the Play Store #14584

Merged
merged 3 commits into from May 9, 2024

Conversation

grorp
Copy link
Member

@grorp grorp commented Apr 24, 2024

This PR makes the Android CI produce an AAB file in addition to APKs.

Note that I have never released anything on the Play Store. @rubenwardy

Oh no, doesn't this make Android CI a lot slower than it already is?

Looks like it doesn't. Gradle seems to do some caching.

To do

This PR is a Ready for Review.

How to test

Look at the CI artifacts.

@grorp grorp added the Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements label Apr 24, 2024
@rubenwardy rubenwardy self-assigned this Apr 24, 2024
@rubenwardy
Copy link
Member

It would be good to release 5.8.1 using this, to try it out

@grorp
Copy link
Member Author

grorp commented Apr 24, 2024

I've added this change to #14548 as well.

Copy link
Member

@rubenwardy rubenwardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works (see 5.8.1)

@grorp grorp merged commit 178591b into minetest:master May 9, 2024
4 checks passed
@grorp grorp deleted the aab-play-store branch May 9, 2024 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Maintenance Tasks to keep the codebase and related parts in order, including architectural improvements One approval ✅ ◻️
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants