[no sq] Server/env optimizations #14582
Merged
+286
−257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sfan5
force-pushed
the
branch2304
branch
2 times, most recently
from
7fe51fb
to
a193f95
Compare
SmallJoker
reviewed
Apr 27, 2024
| for (std::vector<ChangingLight>::const_iterator it = lights.begin(); | ||
| it < lights.end(); ++it) { | ||
| const auto &lights = light_sources.lights[i]; | ||
| for (auto it = lights.begin(); it < lights.end(); ++it) { |
There was a problem hiding this comment.
Range-based for loop would be possible now. Same for the other occurrences.
There was a problem hiding this comment.
I opted to not touch this code too much because it looked non-trivial.
SmallJoker
reviewed
Apr 30, 2024
Due to how node data is stored iterating X last provides better cache locality.
Since this is fixed overhead for every entity, this is important to optimize. This optimizes one very common case. before: push_collision_move_result [us] _____________ 64512x 3.562 after: push_collision_move_result [us] _____________ 72636x 0.831
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I profiled a bit and optimized some functions
"Optimize pushing collision data for entity on_step" -> a good test case is dropping lots of items
(hint: use worldedit to place grass_2 in the air and then punch one)
"Reduce wasteful memory allocations in update_lighting_nodes()" -> this is obvious when you look at the flamegraph for a mod that uses
remove_nodea lot, e.g. worldedits//drain