add sliders to settings #14469
Open
add sliders to settings #14469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zughy
added
Roadmap
y5nw
reviewed
Mar 17, 2024
| local value = core.settings:get(setting.name) or setting.default | ||
| local scrollbar_value = value/(setting.max - setting.min)*steps - setting.min | ||
|
|
||
| self.resettable = true |
There was a problem hiding this comment.
Suggested change
| self.resettable = true | |
| self.resettable = core.settings:has(setting.name) |
Comment on lines
+154
to
+157
| local raw_value = core.explode_scrollbar_event(fields[setting.name]).value | ||
| local value = (raw_value/steps) * (setting.max - setting.min) + setting.min | ||
| core.settings:set(setting.name, tostring(value)) | ||
| return false |
There was a problem hiding this comment.
The value should only be changed if the scrollbar is modified.
Suggested change
| local raw_value = core.explode_scrollbar_event(fields[setting.name]).value | |
| local value = (raw_value/steps) * (setting.max - setting.min) + setting.min | |
| core.settings:set(setting.name, tostring(value)) | |
| return false | |
| local event = core.explode_scrollbar_event(fields[setting.name]) | |
| if event.type ~= "CHG" then | |
| return false | |
| end | |
| local raw_value = event.value | |
| local value = (raw_value/steps) * (setting.max - setting.min) + setting.min | |
| core.settings:set(setting.name, tostring(value)) | |
| return true |
Edit: kotek pointed out in Discord that this somehow breaks mouse dragging.
y5nw
reviewed
Mar 17, 2024
| steps) | ||
| local scrollbar_formspec = ("scrollbar[0,0.5;%f,0.4;horizontal;%s;%f]"):format( | ||
| avail_w - 1, setting.name, scrollbar_value) | ||
| local formspec = setting_label..scrollbar_options..scrollbar_formspec |
There was a problem hiding this comment.
Nitpicking: Why not use table.concat? That would make sense if you want to add more (e.g. value display/input box) to this field.
|
Your feature (which is great, imho) uses |
Zughy
added
the
Action / change needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A compact, short information about PR for easier understanding:
To do
This PR is a
Work in Progress/ Ready for Review.How to test