Fix glitch through celiing with Sneak Glitch

[sfence]

• Goal of the PR
  Fix jump-related bugs.
• How does the PR work?
  Check if there is free space for a jump if sneak_glitch is applied and if the player is not in a collision when the normal jump will happen.
• Does it resolve any reported issue?
  Fix Can glitch through ceiling with Sneak Glitch #11081

To do

This PR is a Ready for Review.

How to test

See #11081.

before:

simplescreenrecorder-2024-02-01_16.11.13.mp4

after;

simplescreenrecorder-2024-02-01_16.07.50.mp4

[SmallJoker]

Generally OK but there's too many lines that show up as modified even though they weren't.

[SmallJoker]

Thank you for splitting the code. I like where this is going so far.

[SmallJoker]

Sneak code performance measurement (code: see below)

master

• sneak: 27.3 us
• no sneak: 24.7 us

PR:

• sneak: 73.5 us
• no sneak: 25.9 us

---

Bug 1:

1. hold sneak until further notice
2. hold the forward key. collide horizontally with a node
3. try to jump - at some chance you can't.
4. release forward key. still cannot jump

This seems to work better when being further away from spawn (e.g. 10000,10,10000)

---

Code for the performance measurement:

diff --git a/src/client/localplayer.cpp b/src/client/localplayer.cpp
index 1470d819a..7c122825b 100644
--- a/src/client/localplayer.cpp
+++ b/src/client/localplayer.cpp
@@ -27,6 +27,7 @@ with this program; if not, write to the Free Software Foundation, Inc.,
 #include "map.h"
 #include "client.h"
 #include "content_cao.h"
+#include "profiler.h"
 
 /*
        LocalPlayer
@@ -202,6 +203,8 @@ void LocalPlayer::move(f32 dtime, Environment *env, f32 pos_max_d,
                return;
        }
 
+       TimeTaker tt("", nullptr, TimePrecision::PRECISION_MICRO);
+
        PlayerSettings &player_settings = getPlayerSettings();
 
        // Skip collision detection if noclip mode is used
@@ -494,6 +497,7 @@ void LocalPlayer::move(f32 dtime, Environment *env, f32 pos_max_d,
 
        // Autojump
        handleAutojump(dtime, env, result, initial_position, initial_speed, pos_max_d);
+       g_profiler->avg("Client: sneak [us]", tt.stop());
 }
 
 void LocalPlayer::move(f32 dtime, Environment *env, f32 pos_max_d)

[sfence]

@grorp What kind of change is needed now?

[grorp]

SmallJoker reported a bug in #14332 (review) on Feb 28, which has not been fixed as far as I can see.

[sfence]

The bug reported by @SmallJoker should be fixed now.

I am not able to reproduce the original glitch. Hopefully due to the new collision detection logic.
But I removed the part of the code, the fix does not work without it before.

So, more testing that the glitch cannot be reproduced is welcome.

[sfence]

Windows build failed due to:

CMake Error at irr/src/CMakeLists.txt:267 (message):
SDL2 is too old, required is at least 2.0.10!

[grorp]

Also, please take a look at the Code style guidelines and adjust newly written code accordingly. (The old code you've only moved can stay as is, that makes reviewing easier.)

[sfence]

Also, please take a look at the Code style guidelines and adjust newly written code accordingly. (The old code you've only moved can stay as is, that makes reviewing easier.)

Checked. Hopefully, I do not miss something.

[SmallJoker]

Whereas this PR technically does what it promises, it does break the sneak glitch slightly.

1. Stand in front of the pillar from the video in the main PR post
2. Hold down forward key
3. Hold down the sneak key
4. Hold down the jump key and sneak-move up by a few steps
5. Release the jump key

• master: player stops at the ledge (minus the sideway movement due to still holding forward)
• PR: falls down

Sometimes this also happens when not moving forward but I found it to be easiest to reproduce this way.

[sfence]

@SmallJoker
Should be fixed now.

[grorp]

IMO having header comments for obvious things in a small function like collision_check_intersection is unnecessary.

Also, please clean up the ScopeProfilers and TimeTakers you copied from collisionMoveSimple which have since been removed by 2e89529

Review is not comprehensive.

[SmallJoker]

The recently mentioned sneak issue is now solved
Collision still works properly. Tested by colliding with a mob_horse entity.

[grorp]

OK

[grorp]

(trivially rebased after #14654)