Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated the Minetest Game screenshot in /media/gallery, issue #265 #302

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

blkkatana
Copy link

Updated the Minetest Game screenshot in /media/gallery to show dynamic shadows and bloom, as wanted in issue #265. Screenshot was taken in Minetest version 5.9.0-dev.

@blkkatana
Copy link
Author

The official repository for minetest.github.io fails the same checks. I don't understand why though.

Copy link
Contributor

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, friendlier scenery, showcases rendering a bit better. Have you tried optimizing file size? (Sizes are still acceptably small, but there is a notable increase).

What may be debatable is that the new screenshot doesn't show HUD, but I think it's better (less cluttered) this way.

There is a "downgrade", though: The new screenshot is relatively low res (old one is 1920 x 1080, new one is 1280 x 678).

@blkkatana
Copy link
Author

I do have the same screenshot with the HUD and a higher resolution (1920 x 1011) if that is preferable.

@appgurueu
Copy link
Contributor

Yes, that would be preferable. Why such an odd resolution though? I would expect 1920 x 1024.

@rollerozxa
Copy link
Member

You should full screen Minetest so it takes a complete 1920x1080 screenshot.

@grorp
Copy link
Member

grorp commented May 8, 2024

The screenshot needs some antialiasing :)

@blkkatana
Copy link
Author

screenshot
I took a new screenshot. How does it look? It's 1920 x 1080, with SSAA turned up to 4. The odd resolution before was because the screenshot wasn't taken in full screen.

@sfan5
Copy link
Member

sfan5 commented May 9, 2024

I have this screenshot lying around, which I think showcases the dynamic shadows better. Unfortunately it's not exactly 1080p:
screenshot_20210623_162552

@blkkatana
Copy link
Author

I like it. Can I use it for my pull request?

@sfan5
Copy link
Member

sfan5 commented May 9, 2024

Sure.

@sfan5
Copy link
Member

sfan5 commented May 9, 2024

Alt text in _data/gallery.yml also needs updating.

@blkkatana
Copy link
Author

Why does it need updating?

@sfan5
Copy link
Member

sfan5 commented May 10, 2024

Nevermind, I accidentally looked at an old revision where it still said "An underwater jungle in Minetest Game".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants