Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add static middle vertical wire #481

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Desour
Copy link
Contributor

@Desour Desour commented Sep 17, 2019

This is highly related to and closes #480. (Sorry that I'm opening a second PR, FranchuFranchu.)

What this PR adds / changes / does and other notes:

  • Everything is tested and works fine.
  • The vertical bottom is visually insulated at the bottom.
  • One new conductor: the static middle vertical wire
  • It can be crafted.
  • It can be rotated (wallmounted).
  • Vertical mesecons connects to it if it's rotated up or down.
  • It can receive signals from buttons and co.
  • Using it should be pretty easy for players.

@Desour
Copy link
Contributor Author

Desour commented Sep 18, 2019

I've done some small improvements and fixes.

@Desour
Copy link
Contributor Author

Desour commented Dec 27, 2019

Would someone like to review or test please btw.?

@leucome
Copy link
Contributor

leucome commented Dec 30, 2019

I use it since the beginning... It work great and it's really useful. I'm not so sure why nobody merged it already. Do it need more review or somebody with some administration privilege or something else?

Digiline also provide a block with the same feature would be nice if Mesecon had it by default too.

@Desour
Copy link
Contributor Author

Desour commented Dec 30, 2019

I use it since the beginning... It work great and it's really useful.

That's nice to hear!

Do it need more review or somebody with some administration privilege or something else?

Somebody would have to review and someone would then have to merge.

Digiline also provide a block with the same feature

What are you referring to? It's probably a digiline expansion, isn't it?

@leucome
Copy link
Contributor

leucome commented Dec 30, 2019

What are you referring to? It's probably a digiline expansion, isn't it?

You are right it come with an other mod called digistuff.

@numberZero
Copy link
Contributor

Rotation is broken: the nodes aren’t updated when they should, and even when they are, some combinations are still problematic.

Conductive Air Power Mesecon
screenshot_20200628_011651 screenshot_20200628_012143

@Desour
Copy link
Contributor Author

Desour commented Jun 28, 2020

Thanks for testing!

The left thing is actually intended. Otherwise it would be weird if there was a mese block and it didn't connect. I know, this is ugly, but player might be used to such connections anyway (eg. from the pipeworks connecting tubes).

I've tried to fix the right thing, but I couldn't get it working correctly. Therefor I've just disabled rotation of active wire.

(I've also rebased.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants