Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate sparse vector in search request #32856

Merged
merged 1 commit into from May 15, 2024

Conversation

zhengbuqian
Copy link
Collaborator

issue: #32368

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label May 8, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels May 8, 2024
Copy link
Contributor

mergify bot commented May 8, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.80%. Comparing base (3d78b90) to head (67b66c6).
Report is 66 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #32856      +/-   ##
==========================================
- Coverage   81.80%   81.80%   -0.01%     
==========================================
  Files        1006      997       -9     
  Lines      126785   127018     +233     
==========================================
+ Hits       103721   103907     +186     
- Misses      19124    19157      +33     
- Partials     3940     3954      +14     
Files Coverage Δ
internal/core/src/common/Utils.h 89.71% <100.00%> (+1.42%) ⬆️
internal/core/src/query/Plan.cpp 56.66% <100.00%> (+1.11%) ⬆️

... and 220 files with indirect coverage changes

@zhengbuqian
Copy link
Collaborator Author

/run-cpu-e2e

Copy link
Contributor

mergify bot commented May 9, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

Signed-off-by: Buqian Zheng <zhengbuqian@gmail.com>
Copy link
Contributor

mergify bot commented May 9, 2024

@zhengbuqian E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

@zhengbuqian
Copy link
Collaborator Author

/run-cpu-e2e

@mergify mergify bot added the ci-passed label May 9, 2024
@czs007
Copy link
Contributor

czs007 commented May 15, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, zhengbuqian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 7c60d72 into milvus-io:master May 15, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/M Denotes a PR that changes 30-99 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants