Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ConfigurationLoader to use 'nodenext' when registering ts-node #5514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vinialbano
Copy link

Update configuration to allow mikro-orm-esm to work with newer versions of tsconfig.

#5427

Copy link

codecov bot commented Apr 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.74%. Comparing base (a6defc1) to head (3a19e93).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5514    +/-   ##
========================================
  Coverage   99.74%   99.74%            
========================================
  Files         260      260            
  Lines       17937    17937            
  Branches     3803     4355   +552     
========================================
  Hits        17892    17892            
  Misses         45       45            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@B4nan
Copy link
Member

B4nan commented Apr 29, 2024

are you sure this doesn't break CJS projects? i think we could maybe remove the overrides completely, as this should be now all taken from the project's tsconfig. maybe we could keep the old behavior when there is no tsconfig found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants