Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash if a component does not mixin Base #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

khoerling
Copy link
Contributor

  • facilitate 3rd-party mixins

- facilitate 3rd-party mixins
@mikemintz
Copy link
Owner

This seems safe to merge, but I'm curious what the scenario is in which updateComponent gets called when a component doesn't use the mixin.

@khoerling
Copy link
Contributor Author

Good question-- it happens in util.js if QueryState is used (for subscriptions).

@mikemintz
Copy link
Owner

I mean, if a component isn't using the react-rethinkdb mixin, why would updateComponent be called?

@khoerling
Copy link
Contributor Author

Here's the line that invokes updateComponent in this case:
https://github.com/mikemintz/react-rethinkdb/blob/master/src/QueryState.js#L107

@mikemintz
Copy link
Owner

That makes sense. But I'm also curious exactly what a React developer would have to do in order to reproduce this crash, since to me it seems like updateComponent wouldn't be called on components that don't use the mixin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants