Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: replace ember assign with Object.assign #617

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tsmalls93
Copy link

Ember assign has been deprecated in this RFC and @ember/polyfills is no longer available in Ember 5.x.

Copy link

@aceol aceol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌🏻 Would be great to have this. Lots of warnings will popup with ember-data update (and it'll broke in v5).
If possible, change also this ligne in the readme:

    payload.data.attributes = assign(payload.data.attributes, attributes);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants