chore: Drop support for Ember v3.19 and below #445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlafroscia
force-pushed
the
bump-minimum-ember-version
branch
from
82569bd
to
9d08a85
Compare
Codecov Report
|
|
I am in favor of this 👍 At first glance, jumping straight to 3.12 as a minimum seems a bit aggressive, but I think it's fair approach regardless. |
BREAKING CHANGE: We are no longer actively testing against Ember versions lower than 3.20
This information is either out-of-date or confusing, since it mentions Ember and Ember Data versions but not which versions of this package work with those combinations. Reading the `README`, one might think that this package actively is tested against and works with each of those Ember/Ember Data pairings, which is not really the case.
Turbo87
force-pushed
the
bump-minimum-ember-version
branch
from
9d08a85
to
298f4cb
Compare
Turbo87
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The need for a change like this came on my radar due to #428, where the tests are valid for newer Ember versions but not for the
2.Xseries.At this point, for a modern add-on, it doesn't make a ton of sense to support these older versions of Ember. If a user needs to use one of these versions, they can stay on the most-recent-at-time-of-writing version the package. Older versions may work in the future, but as we're not testing against then, this should be considered a breaking change (and the commit that bumps the minimum version tested against is marked as such, conventional-commit style).