Add support for .Net 4.5. #411
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for .Net 4.5 to TensorFlowSharp. Along the way I converted all of the build projects to the new, much more concise project format which also allows the projects to target multiple frameworks. I also changed the main project to copy the native tensorflow binaries for the current platform to its output directory to make it easier to build and test and added some documentation about how to build and run the tests to the new file BUILD.md.
Unfortunately with these changes 6 of the csharp tests fail, but the same tests fail on all 3 platforms (.net 4.5, .net 4.6 and newer and netstandard 2.0), and I was unable to get all tests to pass before the changes, so I don't think there is a regression.