Include framework packages during installed packages enumeration (#3975)

microsoft · Dec 14, 2023 · a1a1446 · a1a1446
1 parent 4dc7647
commit a1a1446
Showing 1 changed file with 18 additions and 5 deletions.
diff --git a/src/AppInstallerRepositoryCore/Microsoft/PredefinedInstalledSourceFactory.cpp b/src/AppInstallerRepositoryCore/Microsoft/PredefinedInstalledSourceFactory.cpp
@@ -74,7 +74,7 @@ namespace AppInstaller::Repository::Microsoft
             else
             {
                 // TODO: Consider if Optional packages should also be enumerated
-                packages = packageManager.FindPackagesForUserWithPackageTypes({}, PackageTypes::Main);
+                packages = packageManager.FindPackagesForUserWithPackageTypes({}, PackageTypes::Main | PackageTypes::Framework);
             }
 
             // Reuse the same manifest object, as we will be setting the same values every time.
@@ -157,11 +157,24 @@ namespace AppInstaller::Repository::Microsoft
 
                 manifest.Installers[0].PackageFamilyName = familyName;
 
-                // Use the full name as a unique key for the path
-                auto manifestId = index.AddManifest(manifest, std::filesystem::path{ packageId.FullName().c_str() });
+                try
+                {
+                    // Use the full name as a unique key for the path
+                    auto manifestId = index.AddManifest(manifest, std::filesystem::path{ packageId.FullName().c_str() });
 
-                index.SetMetadataByManifestId(manifestId, PackageVersionMetadata::InstalledType, 
-                    Manifest::InstallerTypeToString(Manifest::InstallerTypeEnum::Msix));
+                    index.SetMetadataByManifestId(manifestId, PackageVersionMetadata::InstalledType,
+                        Manifest::InstallerTypeToString(Manifest::InstallerTypeEnum::Msix));
+                }
+                catch (const wil::ResultException& resultException)
+                {
+                    if (HRESULT_FROM_WIN32(ERROR_ALREADY_EXISTS) == resultException.GetErrorCode() && package.IsFramework())
+                    {
+                        // There may be multiple packages with same package family name for framework packages.
+                        continue;
+                    }
+
+                    throw;
+                }
             }
         }