Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests on Mac fail with ENOTEMPTY: directory not empty #455

Merged
merged 1 commit into from
Feb 21, 2024
Merged

tests on Mac fail with ENOTEMPTY: directory not empty #455

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
12 changes: 6 additions & 6 deletions generators/app/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -189,11 +189,11 @@ export default class extends Generator {

// Git init
if (this.extensionConfig.gitInit) {
this.spawnCommand('git', ['init', '--quiet']);
await this.spawn('git', ['init', '--quiet']);
}

if (this.extensionConfig.proposedAPI) {
this.spawnCommand(this.extensionConfig.pkgManager, ['run', 'update-proposed-api']);
await this.spawn(this.extensionConfig.pkgManager, ['run', 'update-proposed-api']);
}
this.log('');

Expand Down Expand Up @@ -228,20 +228,20 @@ export default class extends Generator {
if (this.options["open"]) {
if (codeStableLocation) {
this.log(`Opening ${this.destinationPath()} in Visual Studio Code...`);
this.spawnCommand(codeStableLocation, [this.destinationPath()]);
await this.spawn(codeStableLocation, [this.destinationPath()]);
} else {
this.log(`'code' command not found.`);
}
} else if (this.options["openInInsiders"]) {
if (codeInsidersLocation) {
this.log(`Opening ${this.destinationPath()} with Visual Studio Code Insiders...`);
this.spawnCommand(codeInsidersLocation, [this.destinationPath()]);
await this.spawn(codeInsidersLocation, [this.destinationPath()]);
} else {
this.log(`'code-insiders' command not found.`);
}
} else if (codeInsidersLocation || codeStableLocation) {
if (this.options["quick"]) {
this.spawnCommand(codeInsidersLocation || codeStableLocation, [this.destinationPath()]);
await this.spawn(codeInsidersLocation || codeStableLocation, [this.destinationPath()]);
} else {
const choices = [];
if (codeInsidersLocation) {
Expand All @@ -259,7 +259,7 @@ export default class extends Generator {
choices
});
if (answer && answer.openWith && answer.openWith !== 'skip') {
this.spawnCommand(answer.openWith, [this.destinationPath()]);
await this.spawn(answer.openWith, [this.destinationPath()]);
}
}
}
Expand Down