Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context to the Copilot Chat #12044

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lukka
Copy link
Member

@lukka lukka commented Mar 1, 2024

@lukka lukka force-pushed the dev/luca/cppcontext branch 2 times, most recently from 5b4dff2 to 47f6624 Compare March 1, 2024 18:38
sean-mcmanus
sean-mcmanus previously approved these changes Mar 1, 2024
Extension/src/LanguageServer/client.ts Outdated Show resolved Hide resolved
@lukka lukka force-pushed the dev/luca/cppcontext branch 2 times, most recently from fde697c to 8877030 Compare March 4, 2024 18:06
Copy link
Member

@bobbrow bobbrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(not actually requesting changes, just blocking the PR until we have approval for the API proposals)

"terminalDataWriteEvent"
"terminalDataWriteEvent",
"chatParticipant",
"chatVariableResolver"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We will need approval to use these APIs before this PR can be approved.

- Using ${language}. Prefer a solution written in ${language} to any other language. Call out which language you are using in the answer.
- Using the ${language} standard language version ${standardVersion}. Prefer solutions using the new and more recent features introduced in ${standardVersion}. Call out which standard version you are using in the answer.
- Using the ${compiler} compiler. Prefer solutions supported by the ${compiler} compiler.
- Targeting the ${targetPlatform} platform. Prefer solutions and API that are supported on ${targetPlatform} .
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's an extra space here -- not sure if that matters though: ${targetPlatform} .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed, thank you!

}

vscode.chat.registerChatVariableResolver('cpp',
`Describes the the C++ language features that can be used according
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

duplicated word "the the"

@sean-mcmanus
Copy link
Collaborator

@lukka Did you want to get these changes into our next release 1.20.2?

@lukka
Copy link
Member Author

lukka commented Apr 9, 2024

@lukka Did you want to get these changes into our next release 1.20.2?

Not yet, thank you for the heads up!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants