[nghttp3] update to 1.3.0 #38846
Draft
[nghttp3] update to 1.3.0 #38846
+17
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
alagoutte
commented
May 21, 2024
alagoutte
commented
- move to vcpkg_download_distfile bcause github archive don't have git submodule
- remove CUnit (not longer used this test framework
move to vcpkg_download_distfile bcause github archive don't have git submodule remove CUnit (not longer used this test framework
Cheney-W
added
the
category:port-update
Cheney-W
reviewed
May 22, 2024
| REF v${VERSION} | ||
| SHA512 7eb776612ddd30b94b9e2b51097038026873c1ca6d8f20565a03674ba648a11833eeb37d1ddd00981f687669e5f3521b61ef5c01dfdbed4f7222046399bd6270 | ||
| HEAD_REF main | ||
| #Don't change to vcpkg_from_github! github archive don't have git submodule |
There was a problem hiding this comment.
What impact does the git submodule have on the building of this port and its downstream usage?
There was a problem hiding this comment.
Use lib/sfparse and munit lib
and sfparse is mandatory now for build
There was a problem hiding this comment.
This could be solved by a second vcpkg_from_github and renaming.
But the actual question is: Should sfparse be a separate port?
There was a problem hiding this comment.
do you have an example with second vcpkg_from_github and renaming ?
There was a problem hiding this comment.
Maybe this one: ports/libgo/portfile.cmake
Picked from git grep 'RENAME.*SOURCE_PATH', because the general pattern is REMOVE_RECURSE + RENAME into SOURCE_PATH/subdir)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.