Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[wolfssl] Build wolfssl with HAVE_EX_DATA and NO_WOLFSSL_STUB to enable async use and coexistence with openssl without link error #38697

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

[wolfssl] Build wolfssl with HAVE_EX_DATA and NO_WOLFSSL_STUB to enable async use and coexistence with openssl without link error #38697

wants to merge 2 commits into from
+2 −2

Conversation

ycdev1
Copy link

@ycdev1 ycdev1 commented May 11, 2024

Async applications using wolfssl need to associate extra data (application context) with the ssl session and context. This is used in verification callback.
NO_WOLFSSL_STUB is needed to prevent a link time error resulting from duplicate symbols when linking to both wolfssl and openssl at the same time

@ycdev1
Update portfile.cmake
a942289 
Build wolfssl with HAVE_EX_DATA and NO_WOLFSSL_STUB to enable async use and coexistence with openssl without link error
@ycdev1
Update wolfssl.json
436610a 
update git-tree for wolfssl version 5.7
@ycdev1
Copy link
Author

ycdev1 commented May 11, 2024

@microsoft-github-policy-service agree

@MonicaLiu0311
Copy link
Contributor

  • Missing edit of vcpkg.json file:
    When there is an upstream version update, please edit the "version" : "x.x.x", such as: 38664/files; when there is no upstream version update, please edit the "port-version": x, which is a field used internally by vcpkg for recording, such as: 31055/files.

  • Submit changes.

  • Run ./vcpkg x-add-version portName [--overwrite-version] to generate version information.

  • Push.

@MonicaLiu0311 MonicaLiu0311 added the category:port-bug The issue is with a library, which is something the port should already support label May 13, 2024
@MonicaLiu0311 MonicaLiu0311 marked this pull request as draft May 13, 2024 02:50
@MonicaLiu0311
Copy link
Contributor

Note: I will be converting your PR to draft status. When you're ready, please revert to "ready for review".

@MonicaLiu0311 MonicaLiu0311 changed the title Build wolfssl with HAVE_EX_DATA and NO_WOLFSSL_STUB to enable async use and coexistence with openssl without link error [wolfssl] Build wolfssl with HAVE_EX_DATA and NO_WOLFSSL_STUB to enable async use and coexistence with openssl without link error May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@MonicaLiu0311 MonicaLiu0311

Labels
category:port-bug The issue is with a library, which is something the port should already support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ycdev1 @MonicaLiu0311