Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[krb5] Update portfile #38685

Draft
wants to merge 4 commits into
base: master
Choose a base branch
from
Draft

[krb5] Update portfile #38685

wants to merge 4 commits into from
+135 −31

Conversation

sharadhr
Copy link
Contributor

@sharadhr sharadhr commented May 10, 2024 •
edited

  • Changes comply with the maintainer guide.
  • SHA512s are updated for each updated download.
  • The "supports" clause reflects platforms that may be fixed by this new version.
  • Any fixed CI baseline entries are removed from that file.
  • Any patches that are no longer applied are deleted from the port's directory.
  • The version database is fixed by rerunning ./vcpkg x-add-version --all and committing the result.
  • Only one version is added to each modified port's versions file.

Sharadh Rajaraman added 2 commits May 10, 2024 18:51
Update krb5
566ce0a 
- install binaries to correct locations
- Don't remove compile_et and krb5-config
- Use GitHub for source
Update krb5 port version
27d0239
@sharadhr
Copy link
Contributor Author

@microsoft-github-policy-service agree

Thomas1664
Thomas1664 reviewed May 10, 2024
View reviewed changes
ports/krb5/portfile.cmake
AUTOCONFIG
NO_ADDITIONAL_PATHS
DETERMINE_BUILD_TRIPLET
OPTIONS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a way to disable building the tools on debug since they will be removed by vcpkg_copy_tools anyway?

@WangWeiLin-MV WangWeiLin-MV added the category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist label May 11, 2024
@sharadhr @WangWeiLin-MV
Update ports/krb5/portfile.cmake
d4a6424 
Use `{VERSION}` portfile variable instead of hard-coding it.

Co-authored-by: WangWeiLin-MV <156736127+WangWeiLin-MV@users.noreply.github.com>
@sharadhr
Copy link
Contributor Author

Thanks everyone for the reviews so far.

It'd be great if this could be tested with any existing ports and non-vcpkg software. I notice curl has a [gssapi] feature; could CI test that it works with these changes?

Additionally, I've been trying to build Samba with this port on macOS, but it hasn't worked and Samba's Waf configure errors out here. It works when using Homebrew krb5, and I'm positive it's a build/install configuration difference that causes the configure to fail.

@talregev talregev mentioned this pull request May 12, 2024
Merged
7 tasks
@dg0yt
Copy link
Contributor

dg0yt commented May 13, 2024

I notice curl has a [gssapi] feature; could CI test that it works with these changes?

Somebody needs to add corresponding dep to the vcpkg-ci-curl test port.

vicroms pushed a commit that referenced this pull request May 23, 2024
@talregev @sharadhr @WangWeiLin-MV
[krb5] Add windows (#38706)
71befd7 
Take elements from this PR: #38685

- [x] Changes comply with the [maintainer
guide](https://github.com/microsoft/vcpkg-docs/blob/main/vcpkg/contributing/maintainer-guide.md).
- [x] SHA512s are updated for each updated download.
- [x] The "supports" clause reflects platforms that may be fixed by this
new version.
- [x] Any fixed [CI
baseline](https://github.com/microsoft/vcpkg/blob/master/scripts/ci.baseline.txt)
entries are removed from that file.
- [x] Any patches that are no longer applied are deleted from the port's
directory.
- [x] The version database is fixed by rerunning `./vcpkg x-add-version
--all` and committing the result.
- [x] Only one version is added to each modified port's versions file.

---------

Co-authored-by: Sharadh Rajaraman <sharadh@cuno.io>
Co-authored-by: Sharadh Rajaraman <3754080+sharadhr@users.noreply.github.com>
Co-authored-by: WangWeiLin-MV <156736127+WangWeiLin-MV@users.noreply.github.com>
@talregev
Copy link
Contributor

@sharadhr My PR merge to the master.
you can merge the changes back and revive your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Thomas1664 Thomas1664 Thomas1664 left review comments

@WangWeiLin-MV WangWeiLin-MV WangWeiLin-MV left review comments

Assignees

@WangWeiLin-MV WangWeiLin-MV

Labels
category:port-feature The issue is with a library, which is requesting new capabilities that didn’t exist
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sharadhr @dg0yt @talregev @Thomas1664 @WangWeiLin-MV