New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libfork] update to version 3.8.0 #38678
Conversation
Not sure why CI is failing, output is this:
Looks like it should be green to me? |
"description": "A bleeding-edge, lock-free, wait-free, continuation-stealing fork-join library built on C++20's coroutines.", | ||
"homepage": "https://github.com/conorwilliams/libfork", | ||
"license": "MPL-2.0", | ||
"dependencies": [ | ||
"boost-atomic", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ConorWilliams, Thanks for your PR, could you please clarify why remove boost-atomic
add pkgconf
dependencies?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@JonLiu1993 libfork used to support boost-atomic
as an optional dependency, this support has been dropped in 3.8 and replaced with a port of just a small portion that was used. The hwloc
package exports a .pc
file which requires pkgconf
to find.
ports/libfork/vcpkg.json
Outdated
"hwloc", | ||
"pkgconf", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't require to build pkgconf
for the target (!).
"pkgconf", |
Instead, modify the portfile:
vcpkg_find_acquire_program(PKGCONFIG)
...
vcpkg_cmake_configure(
...
OPTIONS
"-DPKG_CONFIG_EXECUTABLE=${PKGCONFIG}"
...
)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
BTW it should be verifies that the exported CMake config doesn't contain unresolved imported targets for hwloc.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dg0yt, I have made the changes you suggested
ports/libfork/portfile.cmake
Outdated
OUT_SOURCE_PATH | ||
SOURCE_PATH | ||
REPO | ||
conorwilliams/libfork | ||
REF | ||
"v${VERSION}" | ||
SHA512 | ||
38a8a6fe0f360f1caa123b227996490f192f8b58340ecb5d91922c15d7ca9b364031716e139a3ab0d89cd7cdf3bfb22fcf75272e76a40513c55adaf00ff6454d | ||
HEAD_REF | ||
main) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ConorWilliams, Could you plesae restore the format of this portfile.cmake to its previous format? Comparative standards before.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done, thanks @JonLiu1993
Tested usage successfully by libfork:x64-windows:
|
./vcpkg x-add-version --all
and committing the result.